SAP APPLICATION DEVELOPMENT TEAM Quality Assurance Checklist

SAP Development Objects- Code Review

Object ID & Title SAP Developer Database Administrator Code Reviewer Location of Soft Copy

Program Objects Objects Names Transaction Code Custom tables (if any) Function group Search Help

Object Name

Transport Request #

Have you read and understood Programming standards documents Not Applicable ABAP Developer Code Reviewer

CONTENTS FOR REVIEW Compliance to Development Readiness 1. Versioning/Conflicts - compare development version to production version to ensure no changes are in progress 2. Conflicts - for all changes to substitutions and high traffic user exits review new changes with the on-site coordinator of these areas Compliance to Naming Conventions 3. Adherence to Naming conventions - Object Names (programs, includes, etc) 4. Code Documented 5. Variable Names, Internal Tables & Subroutines 6. Program Structure (order of events in code) 7. Date/Decimal Formats Captured Correctly 8. Multi-Language / Unicode enabling checked Compliance to Technical Specification and Unit Test Plan 9. Program Logic Meets Business Requirements
CFI Technical Team: Check List for SAP Development Quality Review

Page 1 of 5

Updated: 5/19/2011

2005 Warner Bros. Entertainment Inc. All Rights Reserved. CFI Project - Proprietary Confidential

APPLICATION DEVELOPMENT TEAM

10. Selection Screen Layout Meets Requirements 11. Default Values / Search Help for Input Parameters 12. Output Requirements are Met 13. Authority Check Incorporated and Authorization Group assigned to program attributes(if applicable) 14. Error Handling and Reporting is adequate 15. Variants created for Execution (if applicable) 16. Unit Test Plan updated with test cases (both positive and negative test cases) 17. Unit Test Plan test cases performed & documented 18. Unit testing have extremes been tested example testing for empty file or data or zero values, testing full or maximum scenarios, etc. Code and Performance Tuning Checklist (refer to ABAP
Standards doc)

19. Validation Checks Incorporated for Selection screen fields during AT SELECTION SCREEN event 20. Data Declarations are efficient 21. Internal Table usage is efficient 22. Internal table is sorted in correct order which is used in

a READ TABLE statement using BINARY SEARCH.

23. IS NOT INITIAL is checked for the internal table

before making FOR ALL ENTRIES select.

24. Select Appropriate Database Tables for Data Retrieval 25. Exit routines properly designed and programmed 26. Proper use of SELECT statements & INDEX checked 27. Efficient handling Database Updates (COMMITs) 28. Runtime Analysis/SQL Trace is conducted 29. Extended Syntax Check using Code Inspector is done 30. Does every IF or Case ABAP statement has an associated Else covering all possibilities (capture all possible exceptions). 31. Return Code(SY-SUBRC) checked after all database table I/O statements 32. CASE statement used in place of IF where field checked for > 2 values 33. Loops executed without varying clause 34. Check for missing or week WHERE clauses in Select statements. 35. Check for the Wait statements and remove them if all possible. 36. Evaluate modification of tables with in loops and execute them once outside the loop if all possible.
CFI Technical Team: Check List for SAP Development Quality Review Page 2 of 5 Updated: 5/19/2011 ___________________________________________________________________________________________________________

2005 Warner Bros. Entertainment Inc. All Rights Reserved. CFI Project - Proprietary Confidential

APPLICATION DEVELOPMENT TEAM

37. Check whether or not the table indexed to in favor of the select statements. 38. Check for the key work LIKE and attempt to replace it with a stronger selective condition in loops and select statements. 39. Identify Submit statements in loops or Select statements, analyze them and if it possible undo or redo the logic. 40. Re-evaluate select statements within loops and determine if there is a better logic that can be used. 41. Check and replace the Select (*) with Select (parameters / fields). 42. Remove unnecessary Select and End select if there are no operations to be executed on the selected data. 43. Examine the Append statements within loops statements and utilize the newly recommended SAP append statements. 44. Check for and replace if possible Nested loop statements. 45. Incomplete Case statements (include in Case others where missing). 46. End to End monitoring (Interfaces or any RICEF object that moves data from one system to another) Example: the use of ZIDOCDASH or ZOREPORT Administrative checklist 47. Program Attributes are filled in correctly 48. Development Package is assigned correctly 49. Message Class is used correctly 50. Function Groups Created/Assigned Correctly 51. Custom Tables Created/Grouped Correctly 52. Transport Tasks Created Correctly 53. Object Dependencies Verified for Transport 54. Cutover Checklist updated accordingly 55. RICEFW Vital Information updated in FDS/TDS/UTD/Programs 56. Validate ZOVITAL for Object id Information exists across the environments (DEV/QA/Production systems) 57. TDS updated with the latest changes to the program logic, selection, output etc 58. Application server file structures are in place 59. Success/Failure alerts for Applications incorporated 60. Program Documentation incorporated 61. No hard coded values used in the program *
CFI Technical Team: Check List for SAP Development Quality Review Page 3 of 5 Updated: 5/19/2011 ___________________________________________________________________________________________________________

2005 Warner Bros. Entertainment Inc. All Rights Reserved. CFI Project - Proprietary Confidential

APPLICATION DEVELOPMENT TEAM

62. Text Elements and message id used (no hardcoded text strings). 63. Does this object append fields to standard SAP tables? If yes, please notify onsite Development team lead 64. Was there a need to modify and code in a user exit that was already used by other team? If yes, please notify Development team lead 65. Is it a new include or function module? If yes, verify that the Parent is regenerated and included in the transport 66. Is the code in an Include or not the main program? If yes, have you compared the main program version? 67. All debugging code is removed from the program Production Readiness 68. Versioning - compare version between QA and Production systems to ensure correct changes are moving to Production system (Include screenshot of the conflict analysis) 69. When object is shared between different release, make sure you have a task in cookbook to validate future code/logic in PRD for future enhancements 70. When New font family is added for SAPScripts or SMARTForms, make sure device types associated with font family is activated in QA and PROD systems

Comments:
DATABASE ADMINISTRATOR

DEVELOPER (Required)

CODE REVIEWER (Required)

CFI Technical Team: Check List for SAP Development Quality Review Page 4 of 5 Updated: 5/19/2011 ___________________________________________________________________________________________________________

2005 Warner Bros. Entertainment Inc. All Rights Reserved. CFI Project - Proprietary Confidential

APPLICATION DEVELOPMENT TEAM

SIGN-OFF Database Admin. Code Reviewer

Name

Signature

Date

Hard Coding refers particularly to hard coding Master Data values like company code, document types etc. If it is not practical to put these values in a z table, condition table or ZPARAMS make sure that the customer signs off on the hard coding. File signoff with Code Review.

CFI Technical Team: Check List for SAP Development Quality Review Page 5 of 5 Updated: 5/19/2011 ___________________________________________________________________________________________________________

2005 Warner Bros. Entertainment Inc. All Rights Reserved. CFI Project - Proprietary Confidential